diff options
| author | Michael Brown <mcb30@etherboot.org> | 2008-09-30 00:31:02 +0100 |
|---|---|---|
| committer | Michael Brown <mcb30@etherboot.org> | 2008-10-01 08:10:50 +0100 |
| commit | 76f6cad8afd5d7284ecef2b9f74ca22458f7cbdb (patch) | |
| tree | 2e45ae16c6b6d4c01f3058af283961ae971b4f49 | |
| parent | e899f100ca15ce0cbc35f74a5daefda290747147 (diff) | |
| download | ipxe-76f6cad8afd5d7284ecef2b9f74ca22458f7cbdb.tar.gz | |
[hermon] Fix off-by-one error in the failure path in hermon_probe()
| -rw-r--r-- | src/drivers/infiniband/hermon.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/src/drivers/infiniband/hermon.c b/src/drivers/infiniband/hermon.c index f5a8ba0c..3ca60033 100644 --- a/src/drivers/infiniband/hermon.c +++ b/src/drivers/infiniband/hermon.c @@ -2252,9 +2252,9 @@ static int hermon_probe ( struct pci_device *pci, return 0; - i = ( HERMON_NUM_PORTS - 1 ); + i = HERMON_NUM_PORTS; err_register_ibdev: - for ( ; i >= 0 ; i-- ) + for ( i-- ; i >= 0 ; i-- ) unregister_ibdev ( hermon->ibdev[i] ); hermon_destroy_eq ( hermon ); err_create_eq: @@ -2270,9 +2270,9 @@ static int hermon_probe ( struct pci_device *pci, err_mailbox_out: free_dma ( hermon->mailbox_in, HERMON_MBOX_SIZE ); err_mailbox_in: - i = ( HERMON_NUM_PORTS - 1 ); + i = HERMON_NUM_PORTS; err_alloc_ibdev: - for ( ; i >= 0 ; i-- ) + for ( i-- ; i >= 0 ; i-- ) ibdev_put ( hermon->ibdev[i] ); free ( hermon ); err_alloc_hermon: |