diff options
| author | Michael Brown <mcb30@etherboot.org> | 2008-09-30 00:38:10 +0100 |
|---|---|---|
| committer | Michael Brown <mcb30@etherboot.org> | 2008-10-01 08:11:03 +0100 |
| commit | df02c54f867227a4da2e8d5782efdcc602d2ade2 (patch) | |
| tree | 044398eb2fa558a0c44a8e311b3fbaca21e9cfe7 | |
| parent | 76f6cad8afd5d7284ecef2b9f74ca22458f7cbdb (diff) | |
| download | ipxe-df02c54f867227a4da2e8d5782efdcc602d2ade2.tar.gz | |
[arbel] Fix off-by-one error in the failure path in arbel_probe()
| -rw-r--r-- | src/drivers/infiniband/arbel.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/src/drivers/infiniband/arbel.c b/src/drivers/infiniband/arbel.c index 0c180833..1b55131b 100644 --- a/src/drivers/infiniband/arbel.c +++ b/src/drivers/infiniband/arbel.c @@ -2183,9 +2183,9 @@ static int arbel_probe ( struct pci_device *pci, return 0; - i = ( ARBEL_NUM_PORTS - 1 ); + i = ARBEL_NUM_PORTS; err_register_ibdev: - for ( ; i >= 0 ; i-- ) + for ( i-- ; i >= 0 ; i-- ) unregister_ibdev ( arbel->ibdev[i] ); arbel_destroy_eq ( arbel ); err_create_eq: @@ -2201,9 +2201,9 @@ static int arbel_probe ( struct pci_device *pci, err_mailbox_out: free_dma ( arbel->mailbox_in, ARBEL_MBOX_SIZE ); err_mailbox_in: - i = ( ARBEL_NUM_PORTS - 1 ); + i = ARBEL_NUM_PORTS; err_alloc_ibdev: - for ( ; i >= 0 ; i-- ) + for ( i-- ; i >= 0 ; i-- ) ibdev_put ( arbel->ibdev[i] ); free ( arbel ); err_alloc_arbel: |