aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBernat, Yehezkel <yehezkel.bernat@intel.com>2017-08-15 08:19:12 +0300
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2017-09-20 08:27:47 +0200
commit24ed5fd65f7fdc45caeff7edf5f5a95b8d66dedb (patch)
treefe906ceb881209d9aa4eb67fbddb069ed5bb8f0f
parentb92e97e6e5d3ae7bf4472a59f9b40ee589e76ed2 (diff)
downloadlinux-24ed5fd65f7fdc45caeff7edf5f5a95b8d66dedb.tar.gz
thunderbolt: Make key root-only accessible
commit 0956e41169222822d3557871fcd1d32e4fa7e934 upstream. Non-root user may read the key back after root wrote it there. This removes read access to everyone but root. Signed-off-by: Yehezkel Bernat <yehezkel.bernat@intel.com> Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/thunderbolt/switch.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/thunderbolt/switch.c b/drivers/thunderbolt/switch.c
index 69fde0b30eda..8510abcee5d2 100644
--- a/drivers/thunderbolt/switch.c
+++ b/drivers/thunderbolt/switch.c
@@ -826,7 +826,7 @@ static ssize_t key_store(struct device *dev, struct device_attribute *attr,
mutex_unlock(&switch_lock);
return ret;
}
-static DEVICE_ATTR_RW(key);
+static DEVICE_ATTR(key, 0600, key_show, key_store);
static ssize_t nvm_authenticate_show(struct device *dev,
struct device_attribute *attr, char *buf)