diff options
author | Michael Walle <michael@walle.cc> | 2021-05-10 13:07:08 +0200 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2021-05-10 14:48:55 -0700 |
commit | 297c4de6f780b63b6d2af75a730720483bf1904a (patch) | |
tree | 9f7dcaf0f48517ba958bd9e88c8f4ac54bf863b1 /arch/powerpc/xmon/xmon.c | |
parent | 3058e01d31bbdbe50e02cafece2b22817a6a0eae (diff) | |
download | linux-297c4de6f780b63b6d2af75a730720483bf1904a.tar.gz |
net: dsa: felix: re-enable TAS guard band mode
Commit 316bcffe4479 ("net: dsa: felix: disable always guard band bit for
TAS config") disabled the guard band and broke 802.3Qbv compliance.
There are two issues here:
(1) Without the guard band the end of the scheduling window could be
overrun by a frame in transit.
(2) Frames that don't fit into a configured window will still be sent.
The reason for both issues is that the switch will schedule the _start_
of a frame transmission inside the predefined window without taking the
length of the frame into account. Thus, we'll need the guard band which
will close the gate early, so that a complete frame can still be sent.
Revert the commit and add a note.
For a lengthy discussion see [1].
[1] https://lore.kernel.org/netdev/c7618025da6723418c56a54fe4683bd7@walle.cc/
Fixes: 316bcffe4479 ("net: dsa: felix: disable always guard band bit for TAS config")
Signed-off-by: Michael Walle <michael@walle.cc>
Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'arch/powerpc/xmon/xmon.c')
0 files changed, 0 insertions, 0 deletions