diff options
author | Tom Rix <trix@redhat.com> | 2021-04-30 08:50:31 -0700 |
---|---|---|
committer | David Howells <dhowells@redhat.com> | 2021-07-21 15:10:23 +0100 |
commit | afe6949862f77bcc14fa16ad7938a04e84586d6a (patch) | |
tree | ae592adeb8855f9ae68c146733898d85d91c2308 /kernel/cfi.c | |
parent | 6c881ca0b3040f3e724eae513117ba4ddef86057 (diff) | |
download | linux-afe6949862f77bcc14fa16ad7938a04e84586d6a.tar.gz |
afs: check function return
Static analysis reports this problem
write.c:773:29: warning: Assigned value is garbage or undefined
mapping->writeback_index = next;
^ ~~~~
The call to afs_writepages_region() can return without setting
next. So check the function return before using next.
Changes:
ver #2:
- Need to fix the range_cyclic case also[1].
Fixes: e87b03f5830e ("afs: Prepare for use of THPs")
Signed-off-by: Tom Rix <trix@redhat.com>
Signed-off-by: David Howells <dhowells@redhat.com>
Reviewed-by: Marc Dionne <marc.dionne@auristor.com>
cc: linux-afs@lists.infradead.org
Link: https://lore.kernel.org/r/20210430155031.3287870-1-trix@redhat.com
Link: https://lore.kernel.org/r/CAB9dFdvHsLsw7CMnB+4cgciWDSqVjuij4mH3TaXnHQB8sz5rHw@mail.gmail.com/ [1]
Link: https://lore.kernel.org/r/162609464716.3133237.10354897554363093252.stgit@warthog.procyon.org.uk/ # v1
Link: https://lore.kernel.org/r/162610727640.3408253.8687445613469681311.stgit@warthog.procyon.org.uk/ # v2
Diffstat (limited to 'kernel/cfi.c')
0 files changed, 0 insertions, 0 deletions