diff options
author | Takashi Iwai <tiwai@suse.de> | 2022-03-15 17:41:58 +0100 |
---|---|---|
committer | Mark Brown <broonie@kernel.org> | 2022-03-16 16:39:28 +0000 |
commit | 455c5653f50e10b4f460ef24e99f0044fbe3401c (patch) | |
tree | b5632cf661fccd478e11295963bf93f7565c3121 /sound/soc/codecs/lpass-va-macro.c | |
parent | 54e1bf9f6177a3ffbd920474f4481a25361163aa (diff) | |
download | linux-455c5653f50e10b4f460ef24e99f0044fbe3401c.tar.gz |
ASoC: sti: Fix deadlock via snd_pcm_stop_xrun() call
This is essentially a revert of the commit dc865fb9e7c2 ("ASoC: sti:
Use snd_pcm_stop_xrun() helper"), which converted the manual
snd_pcm_stop() calls with snd_pcm_stop_xrun().
The commit above introduced a deadlock as snd_pcm_stop_xrun() itself
takes the PCM stream lock while the caller already holds it. Since
the conversion was done only for consistency reason and the open-call
with snd_pcm_stop() to the XRUN state is a correct usage, let's revert
the commit back as the fix.
Fixes: dc865fb9e7c2 ("ASoC: sti: Use snd_pcm_stop_xrun() helper")
Reported-by: Daniel Palmer <daniel@0x0f.com>
Cc: Arnaud POULIQUEN <arnaud.pouliquen@st.com>
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20220315091319.3351522-1-daniel@0x0f.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Reviewed-by: Arnaud Pouliquen <arnaud.pouliquen@foss.st.com>
Link: https://lore.kernel.org/r/20220315164158.19804-1-tiwai@suse.de
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'sound/soc/codecs/lpass-va-macro.c')
0 files changed, 0 insertions, 0 deletions