diff options
| author | Dandan Bi <dandan.bi@intel.com> | 2016-11-15 19:13:33 +0800 |
|---|---|---|
| committer | Star Zeng <star.zeng@intel.com> | 2016-11-25 14:56:00 +0800 |
| commit | 70091ecec8236cc4e4548babb095e8fc3f7f073c (patch) | |
| tree | 415dd27edc5b798de451357fad96540c2ebc8fac | |
| parent | 155196fca4f438e4756d5b6342803550a3bca226 (diff) | |
| download | edk2-70091ecec8236cc4e4548babb095e8fc3f7f073c.tar.gz | |
MdeModulePkg/SetupBrowser:Don't support password without interactive flag
In current SetupBrowser, the logic related to non-interative password
is not correct. How to support it correctly or whether support it
is still under investigation. First step remove the incorrect logic.
Cc: Liming Gao <liming.gao@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
| -rw-r--r-- | MdeModulePkg/Universal/SetupBrowserDxe/Setup.c | 23 |
1 files changed, 2 insertions, 21 deletions
diff --git a/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c b/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c index 1e7fee3854..23750735f5 100644 --- a/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c +++ b/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c @@ -5581,29 +5581,10 @@ PasswordCheck ( return EFI_UNSUPPORTED;
}
} else {
- if (PasswordString == NULL) {
- return EFI_SUCCESS;
- }
-
- //
- // Check whether has preexisted password.
- //
- if (PasswordString[0] == 0) {
- if (*((CHAR16 *) Question->BufferValue) == 0) {
- return EFI_SUCCESS;
- } else {
- return EFI_NOT_READY;
- }
- }
-
//
- // Check whether the input password is same as preexisted password.
+ // If a password doesn't have the CALLBACK flag, browser will not handle it.
//
- if (StrnCmp (PasswordString, (CHAR16 *) Question->BufferValue, Question->StorageWidth/sizeof (CHAR16)) == 0) {
- return EFI_SUCCESS;
- } else {
- return EFI_NOT_READY;
- }
+ return EFI_UNSUPPORTED;
}
//
|