diff options
| author | Liming Gao <liming.gao@intel.com> | 2018-11-09 07:58:15 +0800 |
|---|---|---|
| committer | Liming Gao <liming.gao@intel.com> | 2018-11-14 08:41:37 +0800 |
| commit | fa01ffdfdf8fef63ea5852547d13639f913659c5 (patch) | |
| tree | 24f13f5af75cd784ad9501c5a074112017808bbd | |
| parent | 78954d8ec6051dd3671dbf86693051c1eee49737 (diff) | |
| download | edk2-fa01ffdfdf8fef63ea5852547d13639f913659c5.tar.gz | |
MdePkg BaseUefiDecompressLib: Fix UEFI Decompression logic issue
https://bugzilla.tianocore.org/show_bug.cgi?id=1317
This is a regression issue caused by 2ec7953d49677142c5f7552e9e3d96fb406ba0c4.
In Decode() function, once mOutBuf is fully filled, Decode() should return.
Current logic misses the checker of mOutBuf after while() loop.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Liming Gao <liming.gao@intel.com>
Cc: Michael Kinney <michael.d.kinney@intel.com>
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com>
(cherry picked from commit 1c4cecc9fd314de0dce8125b0d4b45967637a401)
| -rw-r--r-- | MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLib.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLib.c b/MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLib.c index 23eb87e4bd..956d1e62e8 100644 --- a/MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLib.c +++ b/MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLib.c @@ -641,6 +641,12 @@ Decode ( BytesRemain--;
}
+ //
+ // Once mOutBuf is fully filled, directly return
+ //
+ if (Sd->mOutBuf >= Sd->mOrigSize) {
+ goto Done;
+ }
}
}
|