diff options
| author | Star Zeng <star.zeng@intel.com> | 2018-07-30 10:35:09 +0800 |
|---|---|---|
| committer | Star Zeng <star.zeng@intel.com> | 2018-08-03 08:09:21 +0800 |
| commit | a945963a0d82359e00ecfc28ec27d29aa4fc1b5c (patch) | |
| tree | 61552a40e1e9ad26b2173cec47795240e76081a0 | |
| parent | 0e2bcaababd58aa5f6f5604caad85f8c192e15f9 (diff) | |
| download | edk2-a945963a0d82359e00ecfc28ec27d29aa4fc1b5c.tar.gz | |
FmpDevicePkg FmpDxe: Initialize DeviceLibLowestSupportedVersion
Some static tool reports "DeviceLibLowestSupportedVersion" is used,
but is uninitialized. It is false positive reporting based because
DeviceLibLowestSupportedVersion will have assigned value after
FmpDeviceGetLowestSupportedVersion() returns SUCCESS.
This patch updates the code to initialize
DeviceLibLowestSupportedVersion
to DEFAULT_LOWESTSUPPORTEDVERSION before calling
FmpDeviceGetLowestSupportedVersion().
It can pass the static tool's check.
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng <star.zeng@intel.com>
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
(cherry picked from commit 559b5d5283ac6c0890b35e8684963e35f57f79b9)
| -rw-r--r-- | FmpDevicePkg/FmpDxe/FmpDxe.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/FmpDevicePkg/FmpDxe/FmpDxe.c b/FmpDevicePkg/FmpDxe/FmpDxe.c index b25a1511c7..095cebaa75 100644 --- a/FmpDevicePkg/FmpDxe/FmpDxe.c +++ b/FmpDevicePkg/FmpDxe/FmpDxe.c @@ -229,6 +229,7 @@ GetLowestSupportedVersion ( //
// Check the FmpDeviceLib
//
+ DeviceLibLowestSupportedVersion = DEFAULT_LOWESTSUPPORTEDVERSION;
Status = FmpDeviceGetLowestSupportedVersion (&DeviceLibLowestSupportedVersion);
if (EFI_ERROR (Status)) {
DeviceLibLowestSupportedVersion = DEFAULT_LOWESTSUPPORTEDVERSION;
|