diff options
| author | Star Zeng <star.zeng@intel.com> | 2018-07-31 10:25:49 +0800 |
|---|---|---|
| committer | Star Zeng <star.zeng@intel.com> | 2018-08-03 08:09:28 +0800 |
| commit | b460e9bee8ac938def6c1d286fc991c0b9526826 (patch) | |
| tree | e7744b4958688a775002af25158f1b541f2c512d | |
| parent | 9aa403496902c6ee24bd81acf2bcb96ff2e6a873 (diff) | |
| download | edk2-b460e9bee8ac938def6c1d286fc991c0b9526826.tar.gz | |
FmpDevicePkg FmpDxe: Use local variable to store test key digest size
Some static tool reports "the condition in 'if' statement is constant".
This patch updates the code to use local variable to store test key
digest size. It can pass the static tool's check.
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng <star.zeng@intel.com>
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
(cherry picked from commit d7fb5a46324f1f8a3f0bba7a2ab06ea362ae1053)
| -rw-r--r-- | FmpDevicePkg/FmpDxe/DetectTestKey.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/FmpDevicePkg/FmpDxe/DetectTestKey.c b/FmpDevicePkg/FmpDxe/DetectTestKey.c index 6dedbdfaee..f9b983bb75 100644 --- a/FmpDevicePkg/FmpDxe/DetectTestKey.c +++ b/FmpDevicePkg/FmpDxe/DetectTestKey.c @@ -53,12 +53,14 @@ DetectTestKey ( UINT8 *PublicKeyDataXdrEnd;
VOID *HashContext;
UINT8 Digest[SHA256_DIGEST_SIZE];
+ UINTN TestKeyDigestSize;
//
// If PcdFmpDeviceTestKeySha256Digest is not exacty SHA256_DIGEST_SIZE bytes,
// then skip the test key detection.
//
- if (PcdGetSize (PcdFmpDeviceTestKeySha256Digest) != SHA256_DIGEST_SIZE) {
+ TestKeyDigestSize = PcdGetSize (PcdFmpDeviceTestKeySha256Digest);
+ if (TestKeyDigestSize != SHA256_DIGEST_SIZE) {
return;
}
|