summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMike Maslenkin <mike.maslenkin@gmail.com>2025-01-09 21:10:13 +0300
committerArd Biesheuvel <workofard@gmail.com>2025-01-29 17:20:57 +0100
commitceb87029c50a3fbd59c4ef3e0990da7559fd6ae5 (patch)
treed5e7866fdf191ee4f860b317d4b483e8ee6f3393
parentc58501aa1ab5d1c88d2e9d21d08424b04040f1f1 (diff)
downloadedk2-ceb87029c50a3fbd59c4ef3e0990da7559fd6ae5.tar.gz
SecurityPkg/RngDxe: fix warning about uninitialized variable
ArmTrng.c: In function 'GenerateEntropy': ArmTrng.c:40:15: error: 'Status' may be used uninitialized in this function [-Werror=maybe-uninitialized] EFI_STATUS Status; ^~~~~~ cc1: all warnings being treated as errors Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
-rw-r--r--SecurityPkg/RandomNumberGenerator/RngDxe/ArmTrng.c6
1 files changed, 5 insertions, 1 deletions
diff --git a/SecurityPkg/RandomNumberGenerator/RngDxe/ArmTrng.c b/SecurityPkg/RandomNumberGenerator/RngDxe/ArmTrng.c
index ffe557b692..4036780097 100644
--- a/SecurityPkg/RandomNumberGenerator/RngDxe/ArmTrng.c
+++ b/SecurityPkg/RandomNumberGenerator/RngDxe/ArmTrng.c
@@ -44,6 +44,10 @@ GenerateEntropy (
UINTN Index;
UINTN MaxBits;
+ if ((Length == 0) || (Entropy == NULL)) {
+ return EFI_INVALID_PARAMETER;
+ }
+
ZeroMem (Entropy, Length);
RequiredEntropyBits = (Length << 3);
@@ -67,5 +71,5 @@ GenerateEntropy (
Index += (EntropyBits >> 3);
} // while
- return Status;
+ return EFI_SUCCESS;
}