diff options
| author | Nickle Wang <nicklew@nvidia.com> | 2023-07-13 15:01:47 +0800 |
|---|---|---|
| committer | mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> | 2023-07-17 03:58:02 +0000 |
| commit | 3399f64588428010d48c754f3743bdc8131fa270 (patch) | |
| tree | 67288c31bedb221ddca0446958b7ea7e8f14c79c | |
| parent | dd49d448b0815c65847241a3faa957e3b4605001 (diff) | |
| download | edk2-3399f64588428010d48c754f3743bdc8131fa270.tar.gz | |
RedfishPkg/RedfishRestExDxe: reset session when TCP timeout happens
Call ResetHttpTslSession() to reset HTTP session when TCP timeout
failure happens. So that application can perform retry to the same URI.
Signed-off-by: Nickle Wang <nicklew@nvidia.com>
Cc: Abner Chang <abner.chang@amd.com>
Cc: Igor Kulchytskyy <igork@ami.com>
Cc: Nick Ramirez <nramirez@nvidia.com>
Reviewed-by: Abner Chang <abner.chang@amd.com>
| -rw-r--r-- | RedfishPkg/RedfishRestExDxe/RedfishRestExImpl.c | 4 | ||||
| -rw-r--r-- | RedfishPkg/RedfishRestExDxe/RedfishRestExInternal.h | 14 | ||||
| -rw-r--r-- | RedfishPkg/RedfishRestExDxe/RedfishRestExProtocol.c | 4 |
3 files changed, 20 insertions, 2 deletions
diff --git a/RedfishPkg/RedfishRestExDxe/RedfishRestExImpl.c b/RedfishPkg/RedfishRestExDxe/RedfishRestExImpl.c index 838e24f7e7..b2961424de 100644 --- a/RedfishPkg/RedfishRestExDxe/RedfishRestExImpl.c +++ b/RedfishPkg/RedfishRestExDxe/RedfishRestExImpl.c @@ -4,6 +4,7 @@ Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
(C) Copyright 2020 Hewlett Packard Enterprise Development LP<BR>
Copyright (c) 2023, American Megatrends International LLC.
+ Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent
@@ -12,8 +13,7 @@ #include "RedfishRestExInternal.h"
/**
- Create a new TLS session becuase the previous on is closed.
- status.
+ Create a new TLS session because the previous one is closed.
@param[in] Instance Pointer to EFI_REST_EX_PROTOCOL instance for a particular
REST service.
diff --git a/RedfishPkg/RedfishRestExDxe/RedfishRestExInternal.h b/RedfishPkg/RedfishRestExDxe/RedfishRestExInternal.h index bca679e2cc..c146f4a647 100644 --- a/RedfishPkg/RedfishRestExDxe/RedfishRestExInternal.h +++ b/RedfishPkg/RedfishRestExDxe/RedfishRestExInternal.h @@ -56,6 +56,20 @@ RedfishCheckHttpReceiveStatus ( );
/**
+ Create a new TLS session because the previous one is closed.
+
+ @param[in] Instance Pointer to EFI_REST_EX_PROTOCOL instance for a particular
+ REST service.
+ @retval EFI_SUCCESS operation succeeded.
+ @retval EFI_ERROR Other errors.
+
+**/
+EFI_STATUS
+ResetHttpTslSession (
+ IN RESTEX_INSTANCE *Instance
+ );
+
+/**
This function send the HTTP request without body to see
if the write to URL is permitted by Redfish service. This function
checks if the HTTP request has Content-length in HTTP header. If yes,
diff --git a/RedfishPkg/RedfishRestExDxe/RedfishRestExProtocol.c b/RedfishPkg/RedfishRestExDxe/RedfishRestExProtocol.c index d8f2c73f8e..90973619f2 100644 --- a/RedfishPkg/RedfishRestExDxe/RedfishRestExProtocol.c +++ b/RedfishPkg/RedfishRestExDxe/RedfishRestExProtocol.c @@ -188,6 +188,10 @@ ReSendRequest:; }
if (EFI_ERROR (Status)) {
+ //
+ // Communication failure happens. Reset the session.
+ //
+ ResetHttpTslSession (Instance);
goto ON_EXIT;
}
|