diff options
| author | Ruiyu Ni <ruiyu.ni@intel.com> | 2018-08-03 10:46:34 +0800 |
|---|---|---|
| committer | Ruiyu Ni <ruiyu.ni@intel.com> | 2018-08-06 10:12:14 +0800 |
| commit | 81038d50c9c9bbe5756d6ba172d692d0c7b58a62 (patch) | |
| tree | 1857d03cd8b4ea814a3a26e3191782fe2191944c | |
| parent | c1f032cd3a95ed74dad27d848526495e5790d4af (diff) | |
| download | edk2-81038d50c9c9bbe5756d6ba172d692d0c7b58a62.tar.gz | |
ShellPkg/acpi: Code cleanup to pass static code checker
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
Reviewed-by: Hao Wu <Hao.a.wu@intel.com>
3 files changed, 3 insertions, 2 deletions
diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c index 18c4983e95..5cab20023d 100644 --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c @@ -297,7 +297,7 @@ DumpUint64 ( Val = *(UINT32*)(Ptr + sizeof (UINT32));
Val <<= 32;
- Val |= *(UINT32*)Ptr;
+ Val |= (UINT64)*(UINT32*)Ptr;
Print (Format, Val);
}
diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c index 47ce93f104..4199e82ab1 100644 --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c @@ -284,6 +284,7 @@ ConvertStrToAcpiSignature ( UINT8 Index;
CHAR8 Ptr[4];
+ ZeroMem (Ptr, sizeof (Ptr));
Index = 0;
// Convert to Upper case and convert to ASCII
diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.c index 245700a253..c6eb7087cf 100644 --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.c +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.c @@ -118,7 +118,7 @@ UefiShellAcpiViewCommandLibConstructor ( gShellAcpiViewHiiHandle = NULL;
// Check Shell Profile Debug1 bit of the profiles mask
- if ((FixedPcdGet8 (PcdShellProfileMask) & BIT1) == 0) {
+ if ((PcdGet8 (PcdShellProfileMask) & BIT1) == 0) {
return EFI_SUCCESS;
}
|