diff options
author | Nate DeSimone <nathaniel.l.desimone@intel.com> | 2023-11-30 17:33:14 -0800 |
---|---|---|
committer | mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> | 2023-12-06 22:45:20 +0000 |
commit | df2ec2aab0876d34025968030d1f26ad8e5106ec (patch) | |
tree | 31c074b4e5751ae0d93cf9b730e2adfcc47852df /Maintainers.txt | |
parent | b59ab98049f20f826ff5302a498a435cbb3b3753 (diff) | |
download | edk2-df2ec2aab0876d34025968030d1f26ad8e5106ec.tar.gz |
PcAtChipsetPkg: Fix AcpiTimerLib incompatibility with XhciDxe
The DXE & MM standalone variant of AcpiTimerLib defines a global
named mPerformanceCounterFrequency. A global with an identical
name is also present in MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c
Since XhciDxe has a dependency on TimerLib, this can cause link
errors due to the same symbol being defined twice if the platform
DSC chooses to use AcpiTimerLib as the TimerLib implementation for
any given platform.
To resolve this, I have changed made the definition of
mPerformanceCounterFrequency to static and renamed it to
mAcpiTimerLibTscFrequency. Since this variable is not used outside
of the DxeStandaloneMmAcpiTimerLib.c compilation unit, there is no
reason to have it exported as a global.
Reviewed-by: Ray Ni <ray.ni@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
Diffstat (limited to 'Maintainers.txt')
0 files changed, 0 insertions, 0 deletions