From 3114fd8ed7ce38464572839fe295aca11d704b7d Mon Sep 17 00:00:00 2001 From: Nate DeSimone Date: Wed, 20 Sep 2023 16:18:18 -0700 Subject: EmulatorPkg: Improve comments in WinThunk.c File description has not been updated since Nt32Pkg was merged with EmulatorPkg, and several details were no longer technically accurate. Cc: Andrew Fish Reviewed-by: Ray Ni Cc: Michael D Kinney Cc: Chasel Chiu Signed-off-by: Nate DeSimone --- EmulatorPkg/Win/Host/WinThunk.c | 17 +++++------------ 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/EmulatorPkg/Win/Host/WinThunk.c b/EmulatorPkg/Win/Host/WinThunk.c index 42044f2912..e82735c6a0 100644 --- a/EmulatorPkg/Win/Host/WinThunk.c +++ b/EmulatorPkg/Win/Host/WinThunk.c @@ -10,21 +10,14 @@ Module Name: Abstract: Since the SEC is the only windows program in our emulation we - must use a Tiano mechanism to export Win32 APIs to other modules. - This is the role of the EFI_WIN_NT_THUNK_PROTOCOL. + must use a Tiano mechanism to export operating system services + to other modules. This is the role of the EMU_THUNK_PROTOCOL. - The mWinNtThunkTable exists so that a change to EFI_WIN_NT_THUNK_PROTOCOL + The gEmuThunkProtocol exists so that a change to EMU_THUNK_PROTOCOL will cause an error in initializing the array if all the member functions are not added. It looks like adding a element to end and not initializing - it may cause the table to be initaliized with the members at the end being - set to zero. This is bad as jumping to zero will case the NT32 to crash. - - All the member functions in mWinNtThunkTable are Win32 - API calls, so please reference Microsoft documentation. - - - gWinNt is a a public exported global that contains the initialized - data. + it may cause the table to be initalized with the members at the end being + set to zero. This is bad as jumping to zero will case EmulatorPkg to crash. **/ -- cgit