diff options
| author | Michael Brown <mcb30@ipxe.org> | 2010-09-16 03:23:45 +0100 |
|---|---|---|
| committer | Michael Brown <mcb30@ipxe.org> | 2010-09-16 03:30:45 +0100 |
| commit | 09555826e9737cbe94be99331934d2e6a1e6c8be (patch) | |
| tree | 2e356c0db029cbba37519b912e8b4edc8f51eb88 /src/drivers/infiniband/arbel.c | |
| parent | 5e697b64a57d18f508bdbe29093e78dc7e4af1be (diff) | |
| download | ipxe-09555826e9737cbe94be99331934d2e6a1e6c8be.tar.gz | |
[infiniband] Always call ib_link_state_changed() in ib_smc_update()
ib_smc_update() potentially updates the Infiniband port state, and so
should almost always be followed by a call to ib_link_state_changed().
The one exception is the call made to ib_smc_update() before the
device is registered.
Fix by removing explicit calls to ib_link_state_changed() from drivers
using ib_smc_update(), including a call to ib_link_state_changed()
within ib_smc_update(), and creating a separate ib_smc_init() for use
prior to device registration.
Signed-off-by: Michael Brown <mcb30@ipxe.org>
Diffstat (limited to 'src/drivers/infiniband/arbel.c')
| -rw-r--r-- | src/drivers/infiniband/arbel.c | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/src/drivers/infiniband/arbel.c b/src/drivers/infiniband/arbel.c index 129ec574e..768553270 100644 --- a/src/drivers/infiniband/arbel.c +++ b/src/drivers/infiniband/arbel.c @@ -1436,9 +1436,6 @@ static void arbel_event_port_state_change ( struct arbel *arbel, /* Update MAD parameters */ ib_smc_update ( arbel->ibdev[port], arbel_mad ); - - /* Notify Infiniband core of link state change */ - ib_link_state_changed ( arbel->ibdev[port] ); } /** @@ -2169,9 +2166,9 @@ static int arbel_probe ( struct pci_device *pci, if ( ( rc = arbel_create_eq ( arbel ) ) != 0 ) goto err_create_eq; - /* Update MAD parameters */ + /* Initialise parameters using SMC */ for ( i = 0 ; i < ARBEL_NUM_PORTS ; i++ ) - ib_smc_update ( arbel->ibdev[i], arbel_mad ); + ib_smc_init ( arbel->ibdev[i], arbel_mad ); /* Register Infiniband devices */ for ( i = 0 ; i < ARBEL_NUM_PORTS ; i++ ) { |