diff options
| author | Michael Brown <mcb30@ipxe.org> | 2015-03-04 18:48:19 +0000 |
|---|---|---|
| committer | Michael Brown <mcb30@ipxe.org> | 2015-03-05 00:59:38 +0000 |
| commit | fbc4ba4b4ed13cc86cb8fdea0bac6c3be0164ed5 (patch) | |
| tree | a0c504e297806aa88e89a04e694333a7c5172757 /src/drivers/net/rtl818x | |
| parent | 86ae6e6c1836e43993a14db278398fc54e5419bd (diff) | |
| download | ipxe-fbc4ba4b4ed13cc86cb8fdea0bac6c3be0164ed5.tar.gz | |
[build] Fix the REQUIRE_SYMBOL mechanism
At some point in the past few years, binutils became more aggressive
at removing unused symbols. To function as a symbol requirement, a
relocation record must now be in a section marked with @progbits and
must not be in a section which gets discarded during the link (either
via --gc-sections or via /DISCARD/).
Update REQUIRE_SYMBOL() to generate relocation records meeting these
criteria. To minimise the impact upon the final binary size, we use
existing symbols (specified via the REQUIRING_SYMBOL() macro) as the
relocation targets where possible. We use R_386_NONE or R_X86_64_NONE
relocation types to prevent any actual unwanted relocation taking
place. Where no suitable symbol exists for REQUIRING_SYMBOL() (such
as in config.c), the macro PROVIDE_REQUIRING_SYMBOL() can be used to
generate a one-byte-long symbol to act as the relocation target.
If there are versions of binutils for which this approach fails, then
the fallback will probably involve killing off REQUEST_SYMBOL(),
redefining REQUIRE_SYMBOL() to use the current definition of
REQUEST_SYMBOL(), and postprocessing the linked ELF file with
something along the lines of "nm -u | wc -l" to check that there are
no undefined symbols remaining.
Signed-off-by: Michael Brown <mcb30@ipxe.org>
Diffstat (limited to 'src/drivers/net/rtl818x')
| -rw-r--r-- | src/drivers/net/rtl818x/rtl8180.c | 1 | ||||
| -rw-r--r-- | src/drivers/net/rtl818x/rtl8185.c | 1 |
2 files changed, 2 insertions, 0 deletions
diff --git a/src/drivers/net/rtl818x/rtl8180.c b/src/drivers/net/rtl818x/rtl8180.c index 8851d1bfb..0c7d0775f 100644 --- a/src/drivers/net/rtl818x/rtl8180.c +++ b/src/drivers/net/rtl818x/rtl8180.c @@ -4,6 +4,7 @@ FILE_LICENCE(GPL2_OR_LATER); #include <ipxe/pci.h> +PROVIDE_REQUIRING_SYMBOL(); REQUIRE_OBJECT(rtl818x); REQUIRE_OBJECT(rtl8180_grf5101); REQUIRE_OBJECT(rtl8180_max2820); diff --git a/src/drivers/net/rtl818x/rtl8185.c b/src/drivers/net/rtl818x/rtl8185.c index fd27e5c8c..438c5f24b 100644 --- a/src/drivers/net/rtl818x/rtl8185.c +++ b/src/drivers/net/rtl818x/rtl8185.c @@ -4,6 +4,7 @@ FILE_LICENCE(GPL2_OR_LATER); #include <ipxe/pci.h> +PROVIDE_REQUIRING_SYMBOL(); REQUIRE_OBJECT(rtl818x); REQUIRE_OBJECT(rtl8185_rtl8225); |