diff options
| author | Joshua Oreman <oremanj@rwcr.net> | 2010-05-26 17:52:44 -0700 |
|---|---|---|
| committer | Michael Brown <mcb30@ipxe.org> | 2010-05-27 10:19:14 +0100 |
| commit | 2aad3fab233f0235f9a8f677ae7bb402f1647eb6 (patch) | |
| tree | c4630d1f9e5a2c9d21b7018c63fe20878d1c00af /src/include/ipxe/dhcp.h | |
| parent | ba27168c2e9122859f4d722445e0637a77aab19c (diff) | |
| download | ipxe-2aad3fab233f0235f9a8f677ae7bb402f1647eb6.tar.gz | |
[build] Use weak definitions instead of weak declarations
This removes the need for inline safety wrappers, marginally reducing
the size penalty of weak functions, and works around an apparent
binutils bug that causes undefined weak symbols to not actually be
NULL when compiling with -fPIE (as EFI builds do).
A bug in versions of binutils prior to 2.16 (released in 2005) will
cause same-file weak definitions to not work with those
toolchains. Update the README to reflect our new dependency on
binutils >= 2.16.
Signed-off-by: Joshua Oreman <oremanj@rwcr.net>
Signed-off-by: Michael Brown <mcb30@ipxe.org>
Diffstat (limited to 'src/include/ipxe/dhcp.h')
| -rw-r--r-- | src/include/ipxe/dhcp.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/include/ipxe/dhcp.h b/src/include/ipxe/dhcp.h index bbfa293b1..bbbe73d2c 100644 --- a/src/include/ipxe/dhcp.h +++ b/src/include/ipxe/dhcp.h @@ -630,7 +630,7 @@ extern int start_pxebs ( struct job_interface *job, struct net_device *netdev, * should look for such a packet and call store_cached_dhcpack() with * it if it exists. */ -__weak_decl ( void, get_cached_dhcpack, ( void ), (), ); +extern void get_cached_dhcpack ( void ); extern void store_cached_dhcpack ( userptr_t data, size_t len ); |