diff options
| author | Michael Brown <mcb30@ipxe.org> | 2021-04-10 16:53:52 +0100 |
|---|---|---|
| committer | Michael Brown <mcb30@ipxe.org> | 2021-04-10 16:53:52 +0100 |
| commit | 78749542fc6d31ad41ecc350dea364e21362f985 (patch) | |
| tree | 8ba0a9148d7a3fa3addc9a63e9c69584116b8c4f /src/include/ipxe/netdevice.h | |
| parent | 0be8491b717fec6697dbf6ef8ac07604e062ecb1 (diff) | |
| download | ipxe-78749542fc6d31ad41ecc350dea364e21362f985.tar.gz | |
[netdevice] Ensure driver transmit() and poll() will not be re-entered
When CONSOLE_SYSLOG is used, a DBG() from within a network device
driver may cause its transmit() or poll() methods to be unexpectedly
re-entered. Since these methods are not intended to be re-entrant,
this can lead to undefined behaviour.
Add an explicit re-entrancy guard to both methods. Note that this
must operate at a per-netdevice level, since there are legitimate
circumstances under which the netdev_tx() or netdev_poll() functions
may be re-entered (e.g. when using VLAN devices).
Signed-off-by: Michael Brown <mcb30@ipxe.org>
Diffstat (limited to 'src/include/ipxe/netdevice.h')
| -rw-r--r-- | src/include/ipxe/netdevice.h | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/src/include/ipxe/netdevice.h b/src/include/ipxe/netdevice.h index b9c651c71..294f7b367 100644 --- a/src/include/ipxe/netdevice.h +++ b/src/include/ipxe/netdevice.h @@ -451,6 +451,12 @@ struct net_device { */ #define NETDEV_IRQ_UNSUPPORTED 0x0008 +/** Network device transmission is in progress */ +#define NETDEV_TX_IN_PROGRESS 0x0010 + +/** Network device poll is in progress */ +#define NETDEV_POLL_IN_PROGRESS 0x0020 + /** Link-layer protocol table */ #define LL_PROTOCOLS __table ( struct ll_protocol, "ll_protocols" ) |