diff options
| author | Michael Brown <mcb30@ipxe.org> | 2015-07-28 14:11:35 +0100 |
|---|---|---|
| committer | Michael Brown <mcb30@ipxe.org> | 2015-07-28 14:15:14 +0100 |
| commit | 76338543f9e48833e7c634d947a7ae278f38aef9 (patch) | |
| tree | 37d726df6160da62ffd0494b3a545740faad5a7f /src/net/tcp | |
| parent | 2bcf13f13aff503c47041caaab7cb42bb7ed1484 (diff) | |
| download | ipxe-76338543f9e48833e7c634d947a7ae278f38aef9.tar.gz | |
[iscsi] Add missing "break" statements
iscsi_tx_done() is missing "break" statements at the end of each case.
(Fortunately, this happens not to cause a bug in practice, since
iscsi_login_request_done() is effectively a no-op when completing a
data-out PDU.)
Reported-by: Wissam Shoukair <wissams@mellanox.com>
Signed-off-by: Michael Brown <mcb30@ipxe.org>
Diffstat (limited to 'src/net/tcp')
| -rw-r--r-- | src/net/tcp/iscsi.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/src/net/tcp/iscsi.c b/src/net/tcp/iscsi.c index 0099bf5bd..019a4c14e 100644 --- a/src/net/tcp/iscsi.c +++ b/src/net/tcp/iscsi.c @@ -1439,8 +1439,10 @@ static void iscsi_tx_done ( struct iscsi_session *iscsi ) { switch ( common->opcode & ISCSI_OPCODE_MASK ) { case ISCSI_OPCODE_DATA_OUT: iscsi_data_out_done ( iscsi ); + break; case ISCSI_OPCODE_LOGIN_REQUEST: iscsi_login_request_done ( iscsi ); + break; default: /* No action */ break; |