diff options
| author | Aaron Young <Aaron.Young@oracle.com> | 2019-01-09 11:35:39 -0800 |
|---|---|---|
| committer | Michael Brown <mcb30@ipxe.org> | 2019-01-15 14:12:27 +0000 |
| commit | 3946aa9bac1b4a784924fab1693bfebfdd357438 (patch) | |
| tree | f3d76d225d0f7b16ad5a530c511a125714683bb7 /src/tests | |
| parent | e226fecd1b602ece7f4f208042f3e87ca540b297 (diff) | |
| download | ipxe-3946aa9bac1b4a784924fab1693bfebfdd357438.tar.gz | |
[libc] Fix strcmp()/strncmp() to return proper values
Fix strcmp() and strncmp() to return proper standard positive/negative
values for unequal strings. Current implementation is backwards
(i.e. the functions are returning negative when should be positive and
vice-versa).
Currently all consumers of these functions only check the return value
for ==0 or !=0 and so we can safely change the implementation without
breaking things.
Signed-off-by: Aaron Young <Aaron.Young@oracle.com>
Modified-by: Michael Brown <mcb30@ipxe.org>
Signed-off-by: Michael Brown <mcb30@ipxe.org>
Diffstat (limited to 'src/tests')
| -rw-r--r-- | src/tests/string_test.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/src/tests/string_test.c b/src/tests/string_test.c index 4693b5f65..a66501da3 100644 --- a/src/tests/string_test.c +++ b/src/tests/string_test.c @@ -88,6 +88,7 @@ static void string_test_exec ( void ) { ok ( strcmp ( "Hello", "hello" ) != 0 ); ok ( strcmp ( "Hello", "Hello world!" ) != 0 ); ok ( strcmp ( "Hello world!", "Hello" ) != 0 ); + ok ( strcmp ( "abc", "def" ) < 0 ); /* Test strncmp() */ ok ( strncmp ( "", "", 0 ) == 0 ); |