From 252cff5e9a0b67a27e1837cb674491692b717fd0 Mon Sep 17 00:00:00 2001 From: Michael Brown Date: Wed, 16 Feb 2022 13:22:56 +0000 Subject: [xsigo] Avoid storing unused uninitialised fields in gateway address As reported by Coverity, xsmp_rx_xve_modify() currently passes a partially initialised struct ib_address_vector to xve_update_tca() and thence to eoib_set_gateway(), which uses memcpy() to store the whole structure including the (unused and unneeded) uninitialised fields. Silence the Coverity warning by zeroing the whole structure. Signed-off-by: Michael Brown --- src/net/infiniband/xsigo.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/net/infiniband/xsigo.c b/src/net/infiniband/xsigo.c index 0ee753c38..4f5c618d7 100644 --- a/src/net/infiniband/xsigo.c +++ b/src/net/infiniband/xsigo.c @@ -870,6 +870,7 @@ static int xsmp_rx_xve_modify ( struct xsigo_manager *xcm, * erroneously transmitted as little-endian. */ mtu = ntohs ( msg->mtu ); + memset ( &tca, 0, sizeof ( tca ) ); tca.qpn = ntohl ( msg->tca.data ); tca.qkey = ntohs ( msg->tca.qkey ); tca.gid_present = 1; -- cgit