aboutsummaryrefslogtreecommitdiffstats
path: root/.get_maintainer.ignore
diff options
context:
space:
mode:
authorFranco Venturi <fventuri@comcast.net>2024-07-31 09:09:00 -0400
committerTom Rini <trini@konsulko.com>2024-08-27 18:04:05 -0600
commitcf85cd84aa1a396126448b6d405e458d15f42976 (patch)
tree939787642bbf9e23de26e007dc0170bcd018cede /.get_maintainer.ignore
parent7c2c235a27c7b7198742f37fbe20877e17b6e3ea (diff)
downloadu-boot-WIP/27Aug2024-next.tar.gz
mmc: fix signed vs unsigned compare in read check in _spl_load()WIP/27Aug2024-next
Fix signed vs unsigned compare in read check in _spl_load() Issue: when info->read() returns a negative value because of an error, the comparison of 'read' (signed) with 'sizeof(*header)' (unsigned silently converts the negative value into a very large unsigned value and the check on the error condition always return false, i.e. the error is not detected Symptoms: if spl_load_image_fat() is unable to find the file 'uImage', the SPL phase of the boot process just hangs after displaying the following line: Trying to boot from MMC1 Fix: cast 'sizeof(*header)' to int so the compare is now between signed types Reference: https://stackoverflow.com/questions/17293749/sizeof-operator-in-if-statement Signed-off-by: Franco Venturi <fventuri@comcast.net> Reviewed-by: Sean Anderson <seanga2@gmail.com> Reviewed-by: Peng Fan <peng.fan@nxp.com>
Diffstat (limited to '.get_maintainer.ignore')
0 files changed, 0 insertions, 0 deletions