aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSimon Glass <sjg@chromium.org>2024-10-14 16:31:59 -0600
committerSimon Glass <sjg@chromium.org>2024-10-17 12:45:11 -0600
commit61bb214a3a85bd849a7552c181a27f44fddb35e5 (patch)
treea2fb234921e8677190a2867610748afde7615b75
parent287955b711d8260aaee58416def2e6837c5f2f39 (diff)
downloadu-boot-61bb214a3a85bd849a7552c181a27f44fddb35e5.tar.gz
expo: Add a little more cedit CMOS logging
Add some more logging in the CMOS read/write code. Tidy up a few comments while we are here. Signed-off-by: Simon Glass <sjg@chromium.org>
-rw-r--r--boot/cedit.c6
1 files changed, 4 insertions, 2 deletions
diff --git a/boot/cedit.c b/boot/cedit.c
index cd935d4beba..9d48d3ed50b 100644
--- a/boot/cedit.c
+++ b/boot/cedit.c
@@ -584,7 +584,7 @@ static int h_read_settings_env(struct scene_obj *obj, void *vpriv)
/*
* note that no validation is done here, to make sure the ID is
- * valid * and actually points to a menu item
+ * valid and actually points to a menu item
*/
menu->cur_item_id = val;
break;
@@ -718,6 +718,7 @@ int cedit_write_settings_cmos(struct expo *exp, struct udevice *dev,
}
/* write the data to the RTC */
+ log_debug("Writing CMOS\n");
first = CMOS_MAX_BYTES;
last = -1;
for (i = 0, count = 0; i < CMOS_MAX_BYTES; i++) {
@@ -785,6 +786,7 @@ static int h_read_settings_cmos(struct scene_obj *obj, void *vpriv)
}
/* update the current item */
+ log_debug("look for menuitem value %d in menu %d\n", val, menu->obj.id);
mi = scene_menuitem_find_seq(menu, val);
if (!mi)
return log_msg_ret("seq", -ENOENT);
@@ -819,7 +821,7 @@ int cedit_read_settings_cmos(struct expo *exp, struct udevice *dev,
goto done;
}
- /* read the data to the RTC */
+ /* indicate what bytes were read from the RTC */
first = CMOS_MAX_BYTES;
last = -1;
for (i = 0, count = 0; i < CMOS_MAX_BYTES; i++) {