diff options
| author | Bin Meng <bmeng@tinylab.org> | 2023-07-23 12:40:26 +0800 |
|---|---|---|
| committer | Anatolij Gustschin <agust@denx.de> | 2023-08-01 13:30:41 +0200 |
| commit | caae795a1c6a205498470e9dfc2725ae3052ad12 (patch) | |
| tree | 9c08e5ddfe2de360684b8e5880acdbd732dee737 | |
| parent | 5ee029a190d5c0bf5dcba2f2138d3fa8466e16d6 (diff) | |
| download | u-boot-caae795a1c6a205498470e9dfc2725ae3052ad12.tar.gz | |
video: bochs: Drop the useless argument of bochs_vga_write()
bochs_vga_write() takes 'index' as one argument, but never uses it.
While we are here, use macros instead of magic numbers for the
VGA IO port register name and value.
Signed-off-by: Bin Meng <bmeng@tinylab.org>
Reviewed-by: Simon Glass <sjg@chromium.org>
Tested-by: Simon Glass <sjg@chromium.org> # qemu-x86_64
| -rw-r--r-- | drivers/video/bochs.c | 7 | ||||
| -rw-r--r-- | drivers/video/bochs.h | 5 |
2 files changed, 8 insertions, 4 deletions
diff --git a/drivers/video/bochs.c b/drivers/video/bochs.c index fa0283c158a..2d4526c7143 100644 --- a/drivers/video/bochs.c +++ b/drivers/video/bochs.c @@ -27,9 +27,9 @@ static int bochs_read(void *mmio, int index) return readw(mmio + MMIO_BASE + index * 2); } -static void bochs_vga_write(int index, uint8_t val) +static void bochs_vga_write(uint8_t val) { - outb(val, VGA_INDEX); + outb(val, VGA_ATT_W); } static int bochs_init_fb(struct udevice *dev) @@ -78,7 +78,8 @@ static int bochs_init_fb(struct udevice *dev) bochs_write(mmio, INDEX_Y_OFFSET, 0); bochs_write(mmio, INDEX_ENABLE, ENABLED | LFB_ENABLED); - bochs_vga_write(0, 0x20); /* disable blanking */ + /* disable blanking */ + bochs_vga_write(VGA_AR_ENABLE_DISPLAY); plat->base = fb; diff --git a/drivers/video/bochs.h b/drivers/video/bochs.h index 4c8ec83a550..71d3d60141e 100644 --- a/drivers/video/bochs.h +++ b/drivers/video/bochs.h @@ -6,7 +6,10 @@ #ifndef __BOCHS_H #define __BOCHS_H -#define VGA_INDEX 0x3c0 +#define VGA_INDEX 0x3c0 + +#define VGA_ATT_W 0x3c0 +#define VGA_AR_ENABLE_DISPLAY 0x20 #define IOPORT_INDEX 0x01ce #define IOPORT_DATA 0x01cf |