diff options
author | Masahiro Yamada <masahiroy@kernel.org> | 2020-06-26 15:13:33 +0900 |
---|---|---|
committer | Tom Rini <trini@konsulko.com> | 2020-07-17 09:30:13 -0400 |
commit | b75d8dc5642b71eb029e7cd38031a32029e736cc (patch) | |
tree | e13a2c309a27c528a79f7c49b468c0c2d246a499 /board/freescale/mpc8569mds/mpc8569mds.c | |
parent | 02ff91e8c60f1f48bee8f4bd1c87ea0892cc5dae (diff) | |
download | u-boot-b75d8dc5642b71eb029e7cd38031a32029e736cc.tar.gz |
treewide: convert bd_t to struct bd_info by coccinelle
The Linux coding style guide (Documentation/process/coding-style.rst)
clearly says:
It's a **mistake** to use typedef for structures and pointers.
Besides, using typedef for structures is annoying when you try to make
headers self-contained.
Let's say you have the following function declaration in a header:
void foo(bd_t *bd);
This is not self-contained since bd_t is not defined.
To tell the compiler what 'bd_t' is, you need to include <asm/u-boot.h>
#include <asm/u-boot.h>
void foo(bd_t *bd);
Then, the include direcective pulls in more bloat needlessly.
If you use 'struct bd_info' instead, it is enough to put a forward
declaration as follows:
struct bd_info;
void foo(struct bd_info *bd);
Right, typedef'ing bd_t is a mistake.
I used coccinelle to generate this commit.
The semantic patch that makes this change is as follows:
<smpl>
@@
typedef bd_t;
@@
-bd_t
+struct bd_info
</smpl>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Diffstat (limited to 'board/freescale/mpc8569mds/mpc8569mds.c')
-rw-r--r-- | board/freescale/mpc8569mds/mpc8569mds.c | 15 |
1 files changed, 8 insertions, 7 deletions
diff --git a/board/freescale/mpc8569mds/mpc8569mds.c b/board/freescale/mpc8569mds/mpc8569mds.c index 90b9c72babb..1d2cffbacdf 100644 --- a/board/freescale/mpc8569mds/mpc8569mds.c +++ b/board/freescale/mpc8569mds/mpc8569mds.c @@ -308,7 +308,8 @@ local_bus_init(void) out_be32(&lbc->lcrr, (u32)in_be32(&lbc->lcrr)| 0x00030000); } -static void fdt_board_disable_serial(void *blob, bd_t *bd, const char *alias) +static void fdt_board_disable_serial(void *blob, struct bd_info *bd, + const char *alias) { const char *status = "disabled"; int off; @@ -353,7 +354,7 @@ static int esdhc_disables_uart0(void) hwconfig_subarg_cmp("esdhc", "mode", "4-bits"); } -static void fdt_board_fixup_qe_uart(void *blob, bd_t *bd) +static void fdt_board_fixup_qe_uart(void *blob, struct bd_info *bd) { u8 *bcsr = (u8 *)CONFIG_SYS_BCSR_BASE; const char *devtype = "serial"; @@ -400,7 +401,7 @@ static void fdt_board_fixup_qe_uart(void *blob, bd_t *bd) #ifdef CONFIG_FSL_ESDHC -int board_mmc_init(bd_t *bd) +int board_mmc_init(struct bd_info *bd) { struct ccsr_gur *gur = (struct ccsr_gur *)CONFIG_SYS_MPC85xx_GUTS_ADDR; u8 *bcsr = (u8 *)CONFIG_SYS_BCSR_BASE; @@ -441,7 +442,7 @@ int board_mmc_init(bd_t *bd) return fsl_esdhc_mmc_init(bd); } -static void fdt_board_fixup_esdhc(void *blob, bd_t *bd) +static void fdt_board_fixup_esdhc(void *blob, struct bd_info *bd) { const char *status = "disabled"; int off = -1; @@ -481,10 +482,10 @@ static void fdt_board_fixup_esdhc(void *blob, bd_t *bd) } } #else -static inline void fdt_board_fixup_esdhc(void *blob, bd_t *bd) {} +static inline void fdt_board_fixup_esdhc(void *blob, struct bd_info *bd) {} #endif -static void fdt_board_fixup_qe_usb(void *blob, bd_t *bd) +static void fdt_board_fixup_qe_usb(void *blob, struct bd_info *bd) { u8 *bcsr = (u8 *)CONFIG_SYS_BCSR_BASE; @@ -518,7 +519,7 @@ void pci_init_board(void) #endif /* CONFIG_PCI */ #if defined(CONFIG_OF_BOARD_SETUP) -int ft_board_setup(void *blob, bd_t *bd) +int ft_board_setup(void *blob, struct bd_info *bd) { #if defined(CONFIG_SYS_UCC_RMII_MODE) int nodeoff, off, err; |