diff options
| author | Jonas Karlman <jonas@kwiboo.se> | 2023-08-31 22:16:33 +0000 |
|---|---|---|
| committer | Tom Rini <trini@konsulko.com> | 2023-09-13 15:52:20 -0400 |
| commit | feb4b919abf39f39faf660ef3d9aedebb54f5db5 (patch) | |
| tree | bcdfdcb2064cbe5c297d5d37e654b8fe495c317b /drivers/phy/phy-uclass.c | |
| parent | cba79a1b2e1155eb69802cc9a8e7d1d856237f67 (diff) | |
| download | u-boot-feb4b919abf39f39faf660ef3d9aedebb54f5db5.tar.gz | |
phy: Set phy->dev to NULL when generic_phy_get_by_name() fails
generic_phy_get_by_name() does not initialize phy->dev to NULL before
returning when dev_read_stringlist_search() fails. This can lead to an
uninitialized or reused struct phy erroneously be report as valid by
generic_phy_valid().
Fix this issue by initializing phy->dev to NULL, also extend the
dm_test_phy_base test with calls to generic_phy_valid().
Fixes: b9688df3cbf4 ("drivers: phy: Set phy->dev to NULL when generic_phy_get_by_index() fails")
Fixes: 868d58f69c7c ("usb: dwc3: Fix non-usb3 configurations")
Signed-off-by: Jonas Karlman <jonas@kwiboo.se>
Diffstat (limited to 'drivers/phy/phy-uclass.c')
| -rw-r--r-- | drivers/phy/phy-uclass.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/phy/phy-uclass.c b/drivers/phy/phy-uclass.c index 629ef3aa3de..0baf314a347 100644 --- a/drivers/phy/phy-uclass.c +++ b/drivers/phy/phy-uclass.c @@ -211,6 +211,9 @@ int generic_phy_get_by_name(struct udevice *dev, const char *phy_name, debug("%s(dev=%p, name=%s, phy=%p)\n", __func__, dev, phy_name, phy); + assert(phy); + phy->dev = NULL; + index = dev_read_stringlist_search(dev, "phy-names", phy_name); if (index < 0) { debug("dev_read_stringlist_search() failed: %d\n", index); |