From 5a04264ecf5f0f853f2d562b4c5efb139d3d4a9d Mon Sep 17 00:00:00 2001 From: Yaniv Levinsky Date: Sun, 24 Jun 2018 19:16:56 +0300 Subject: cmd: nvedit: set H_INTERACTIVE in do_env_default The function set_default_vars() in common.c adds H_INTERACTIVE to the h_import() flag, but the function has no way of telling if the command actually was user directed like this flag suggest. The flag should be set by the calling function do_env_default() in nvedit.c instead, where the command is certainty user directed. Move the H_INTERACTIVE flag from set_default_vars() to do_env_default(). Signed-off-by: Yaniv Levinsky Acked-by: Igor Grinberg --- cmd/nvedit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'cmd/nvedit.c') diff --git a/cmd/nvedit.c b/cmd/nvedit.c index 1955dee0d02..8b73c606ca6 100644 --- a/cmd/nvedit.c +++ b/cmd/nvedit.c @@ -780,7 +780,7 @@ int envmatch(uchar *s1, int i2) static int do_env_default(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) { - int all = 0, env_flag = 0; + int all = 0, env_flag = H_INTERACTIVE; debug("Initial value for argc=%d\n", argc); while (--argc > 0 && **++argv == '-') { -- cgit