diff options
| author | Matt DeVillier <matt.devillier@gmail.com> | 2019-12-12 21:51:19 -0600 |
|---|---|---|
| committer | Kevin O'Connor <kevin@koconnor.net> | 2020-03-06 08:27:38 -0500 |
| commit | 24d3938ca96a6420ec1a5f1f8479f90f2e9fdd56 (patch) | |
| tree | 690365ffc6fda94f9b3dd9e0224009238b8e607b /src/hw | |
| parent | 81ddc4c6ecafe2b7ca2ee4ac78d405272208fe86 (diff) | |
| download | seabios-24d3938ca96a6420ec1a5f1f8479f90f2e9fdd56.tar.gz | |
hw/usb-hid: Don't abort if setting key repeat rate fails
Since the USB stack doesn't handle stalled pipes,
don't abort keyboard setup if the set_idle command fails,
since it's a non-critical feature. Instead, log a warning.
Test: build/boot Google Pixel Slate, observe keyboard functional
Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>
Signed-off-by: Matt DeVillier <matt.devillier@gmail.com>
Diffstat (limited to 'src/hw')
| -rw-r--r-- | src/hw/usb-hid.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/hw/usb-hid.c b/src/hw/usb-hid.c index 5965304c..a22765b0 100644 --- a/src/hw/usb-hid.c +++ b/src/hw/usb-hid.c @@ -82,7 +82,7 @@ usb_kbd_setup(struct usbdevice_s *usbdev // Periodically send reports to enable key repeat. ret = set_idle(usbdev->defpipe, KEYREPEATMS); if (ret) - return -1; + dprintf(3, "Warning: Failed to set key repeat rate\n"); keyboard_pipe = usb_alloc_pipe(usbdev, epdesc); if (!keyboard_pipe) |