diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2021-12-15 14:49:01 +0300 |
|---|---|---|
| committer | Rob Clark <robdclark@chromium.org> | 2021-12-15 15:28:40 -0800 |
| commit | 48d0cf4a7cf2d5447f997e232c6378bb02434655 (patch) | |
| tree | 069ecc59524be5b5412f9c0adbb4e1b0e915eae4 /drivers/gpu/drm/msm/dp/dp_drm.c | |
| parent | 37897856ab1e3772994c71df3b6fc71fe508518d (diff) | |
| download | linux-48d0cf4a7cf2d5447f997e232c6378bb02434655.tar.gz | |
drm/msm/dp: Fix double free on error in msm_dp_bridge_init()
The "dp_bridge" pointer is allocated with devm_kzalloc() so it will be
freed automatically. Kfreeing it here will only lead to a double free.
Fixes: 8a3b4c17f863 ("drm/msm/dp: employ bridge mechanism for display enable and disable")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Link: https://lore.kernel.org/r/20211215114900.GD14552@kili
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Signed-off-by: Rob Clark <robdclark@chromium.org>
Diffstat (limited to 'drivers/gpu/drm/msm/dp/dp_drm.c')
| -rw-r--r-- | drivers/gpu/drm/msm/dp/dp_drm.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/gpu/drm/msm/dp/dp_drm.c b/drivers/gpu/drm/msm/dp/dp_drm.c index 188e77c59885..d4d360d19eba 100644 --- a/drivers/gpu/drm/msm/dp/dp_drm.c +++ b/drivers/gpu/drm/msm/dp/dp_drm.c @@ -243,7 +243,6 @@ struct drm_bridge *msm_dp_bridge_init(struct msm_dp *dp_display, struct drm_devi rc = drm_bridge_attach(encoder, bridge, NULL, DRM_BRIDGE_ATTACH_NO_CONNECTOR); if (rc) { DRM_ERROR("failed to attach bridge, rc=%d\n", rc); - kfree(dp_bridge); return ERR_PTR(rc); } |