diff options
author | Bjorn Helgaas <bhelgaas@google.com> | 2020-08-05 18:24:22 -0500 |
---|---|---|
committer | Bjorn Helgaas <bhelgaas@google.com> | 2020-08-05 18:24:22 -0500 |
commit | 6f119ec8d9c8f68c0432d902312045a699c3e52a (patch) | |
tree | 37a77220c6301b947b778a45e314719e20028a79 /drivers/pci/controller/mobiveil | |
parent | 65c2bc6ce972e7aee1523a0702d0eeac0570a01f (diff) | |
parent | caecb05c800081c57907749f787f05f62011564e (diff) | |
download | linux-6f119ec8d9c8f68c0432d902312045a699c3e52a.tar.gz |
Merge branch 'pci/irq-error'
- Remove redundant logging for platform_get_irq() errors (Krzysztof
WilczyĆski)
* pci/irq-error:
PCI: Remove dev_err() when handing an error from platform_get_irq()
Diffstat (limited to 'drivers/pci/controller/mobiveil')
-rw-r--r-- | drivers/pci/controller/mobiveil/pcie-layerscape-gen4.c | 5 | ||||
-rw-r--r-- | drivers/pci/controller/mobiveil/pcie-mobiveil-host.c | 4 |
2 files changed, 3 insertions, 6 deletions
diff --git a/drivers/pci/controller/mobiveil/pcie-layerscape-gen4.c b/drivers/pci/controller/mobiveil/pcie-layerscape-gen4.c index a6d2190a6753..ee0156921ebc 100644 --- a/drivers/pci/controller/mobiveil/pcie-layerscape-gen4.c +++ b/drivers/pci/controller/mobiveil/pcie-layerscape-gen4.c @@ -170,10 +170,9 @@ static int ls_pcie_g4_interrupt_init(struct mobiveil_pcie *mv_pci) int ret; pcie->irq = platform_get_irq_byname(pdev, "intr"); - if (pcie->irq < 0) { - dev_err(dev, "Can't get 'intr' IRQ, errno = %d\n", pcie->irq); + if (pcie->irq < 0) return pcie->irq; - } + ret = devm_request_irq(dev, pcie->irq, ls_pcie_g4_isr, IRQF_SHARED, pdev->name, pcie); if (ret) { diff --git a/drivers/pci/controller/mobiveil/pcie-mobiveil-host.c b/drivers/pci/controller/mobiveil/pcie-mobiveil-host.c index 33ab36d73906..3adec419a45b 100644 --- a/drivers/pci/controller/mobiveil/pcie-mobiveil-host.c +++ b/drivers/pci/controller/mobiveil/pcie-mobiveil-host.c @@ -519,10 +519,8 @@ static int mobiveil_pcie_integrated_interrupt_init(struct mobiveil_pcie *pcie) mobiveil_pcie_enable_msi(pcie); rp->irq = platform_get_irq(pdev, 0); - if (rp->irq < 0) { - dev_err(dev, "failed to map IRQ: %d\n", rp->irq); + if (rp->irq < 0) return rp->irq; - } /* initialize the IRQ domains */ ret = mobiveil_pcie_init_irq_domain(pcie); |