diff options
author | Song Liu <songliubraving@fb.com> | 2021-10-03 22:32:38 -0700 |
---|---|---|
committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2021-10-31 12:51:41 -0300 |
commit | 29c77550eef31b0d72a45b49eeab03b8963264e8 (patch) | |
tree | 9853fa319869458ac97e8b5ad05164729102179c /scripts/decodecode | |
parent | 095729484efc4aa4604c474792b059bd940addce (diff) | |
download | linux-29c77550eef31b0d72a45b49eeab03b8963264e8.tar.gz |
perf script: Check session->header.env.arch before using it
When perf.data is not written cleanly, we would like to process existing
data as much as possible (please see f_header.data.size == 0 condition
in perf_session__read_header). However, perf.data with partial data may
crash perf. Specifically, we see crash in 'perf script' for NULL
session->header.env.arch.
Fix this by checking session->header.env.arch before using it to determine
native_arch. Also split the if condition so it is easier to read.
Committer notes:
If it is a pipe, we already assume is a native arch, so no need to check
session->header.env.arch.
Signed-off-by: Song Liu <songliubraving@fb.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: kernel-team@fb.com
Cc: stable@vger.kernel.org
Link: http://lore.kernel.org/lkml/20211004053238.514936-1-songliubraving@fb.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'scripts/decodecode')
0 files changed, 0 insertions, 0 deletions