diff options
| author | Vineel Kovvuri[MSFT] <vineelko@microsoft.com> | 2024-10-25 16:37:01 -0700 |
|---|---|---|
| committer | mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> | 2025-01-15 11:18:04 +0000 |
| commit | aae044a130599427e3562fe5736d7b2d42777272 (patch) | |
| tree | 798ed1db391a70720d5006749bab80d02a469ac0 /EmbeddedPkg | |
| parent | d6f828b3849e5adcf9a04d3c16e79388db9b3614 (diff) | |
| download | edk2-aae044a130599427e3562fe5736d7b2d42777272.tar.gz | |
EmbeddedPkg: CodeQL Fixes.
Makes changes to comply with alerts raised by CodeQL.
Most of the issues here fall into the following two categories:
1. Potential use of uninitialized pointer.
2. Inconsistent integer width in comparison.
Co-authored-by: Taylor Beebe <taylor.d.beebe@gmail.com>
Co-authored-by: Ken Lautner <kenlautner3@gmail.com>
Co-authored-by: Bret Barkelew <bret@corthon.com>
Signed-off-by: Vineel Kovvuri[MSFT] <vineelko@microsoft.com>
Diffstat (limited to 'EmbeddedPkg')
| -rw-r--r-- | EmbeddedPkg/Library/PrePiHobLib/Hob.c | 3 | ||||
| -rw-r--r-- | EmbeddedPkg/Library/PrePiLib/FwVol.c | 2 | ||||
| -rw-r--r-- | EmbeddedPkg/SimpleTextInOutSerial/SimpleTextInOut.c | 3 |
3 files changed, 7 insertions, 1 deletions
diff --git a/EmbeddedPkg/Library/PrePiHobLib/Hob.c b/EmbeddedPkg/Library/PrePiHobLib/Hob.c index 9c450c0c87..a394ca00b4 100644 --- a/EmbeddedPkg/Library/PrePiHobLib/Hob.c +++ b/EmbeddedPkg/Library/PrePiHobLib/Hob.c @@ -498,6 +498,9 @@ BuildGuidDataHob ( ASSERT (Data != NULL || DataLength == 0);
HobData = BuildGuidHob (Guid, DataLength);
+ if (HobData == NULL) {
+ return NULL;
+ }
return CopyMem (HobData, Data, DataLength);
}
diff --git a/EmbeddedPkg/Library/PrePiLib/FwVol.c b/EmbeddedPkg/Library/PrePiLib/FwVol.c index 7739a5c8aa..cfb1ff46b7 100644 --- a/EmbeddedPkg/Library/PrePiLib/FwVol.c +++ b/EmbeddedPkg/Library/PrePiLib/FwVol.c @@ -283,7 +283,7 @@ FfsProcessSection ( {
EFI_STATUS Status;
UINT32 SectionLength;
- UINT32 ParsedLength;
+ UINTN ParsedLength;
EFI_COMPRESSION_SECTION *CompressionSection;
EFI_COMPRESSION_SECTION2 *CompressionSection2;
UINT32 DstBufferSize;
diff --git a/EmbeddedPkg/SimpleTextInOutSerial/SimpleTextInOut.c b/EmbeddedPkg/SimpleTextInOutSerial/SimpleTextInOut.c index 32944a8d9d..2a15f23771 100644 --- a/EmbeddedPkg/SimpleTextInOutSerial/SimpleTextInOut.c +++ b/EmbeddedPkg/SimpleTextInOutSerial/SimpleTextInOut.c @@ -504,6 +504,9 @@ OutputString ( Size = StrLen (String) + 1;
OutputString = AllocatePool (Size);
+ if (OutputString == NULL) {
+ return EFI_OUT_OF_RESOURCES;
+ }
// If there is any non-ascii characters in String buffer then replace it with '?'
// Eventually, UnicodeStrToAsciiStr API should be fixed.
|