aboutsummaryrefslogtreecommitdiffstats
path: root/src/crypto
diff options
context:
space:
mode:
Diffstat (limited to 'src/crypto')
-rw-r--r--src/crypto/bigint.c5
-rw-r--r--src/crypto/x25519.c3
2 files changed, 3 insertions, 5 deletions
diff --git a/src/crypto/bigint.c b/src/crypto/bigint.c
index 3f5db8517..35701a1d0 100644
--- a/src/crypto/bigint.c
+++ b/src/crypto/bigint.c
@@ -162,14 +162,13 @@ void bigint_reduce_raw ( const bigint_element_t *minuend0,
bigint_t ( minuend_size ) modulus;
} *temp = tmp;
const unsigned int width = ( 8 * sizeof ( bigint_element_t ) );
- const bigint_element_t msb_mask = ( 1UL << ( width - 1 ) );
bigint_element_t *element;
unsigned int minuend_max;
unsigned int modulus_max;
unsigned int subshift;
- bigint_element_t msb;
int offset;
int shift;
+ int msb;
int i;
/* Start profiling */
@@ -289,7 +288,7 @@ void bigint_reduce_raw ( const bigint_element_t *minuend0,
} else {
bigint_subtract ( &temp->modulus, &temp->minuend );
}
- msb = ( temp->minuend.element[ minuend_size - 1 ] & msb_mask );
+ msb = bigint_msb_is_set ( &temp->minuend );
if ( shift > 0 )
bigint_shr ( &temp->modulus );
}
diff --git a/src/crypto/x25519.c b/src/crypto/x25519.c
index d58f7168c..19f9a2c02 100644
--- a/src/crypto/x25519.c
+++ b/src/crypto/x25519.c
@@ -563,7 +563,6 @@ void x25519_invert ( const union x25519_oct258 *invertend,
* @v value Big integer to be subtracted from, if possible
*/
static void x25519_reduce_by ( const x25519_t *subtrahend, x25519_t *value ) {
- unsigned int max_bit = ( ( 8 * sizeof ( *value ) ) - 1 );
x25519_t tmp;
/* Conditionally subtract subtrahend
@@ -573,7 +572,7 @@ static void x25519_reduce_by ( const x25519_t *subtrahend, x25519_t *value ) {
*/
bigint_copy ( value, &tmp );
bigint_subtract ( subtrahend, value );
- bigint_swap ( value, &tmp, bigint_bit_is_set ( value, max_bit ) );
+ bigint_swap ( value, &tmp, bigint_msb_is_set ( value ) );
}
/**